Size Change: +90 B (0%)

Total Size: 1.51 MB

_{compressed-size-action}

Flaky tests detected in dc66a2f.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5971249296
📝 Reported issues:

• [Flaky Test] Should NOT load the view script if the lightbox is disabled in theme.json and in block settings #53802 in /test/e2e/specs/editor/various/behaviors.spec.js

Looking really good @glendaviesnz !

Might just be me, but now user patterns have merged, the separation of My patterns from the rest of the categories felt a bit off. I'm no designer though

I think we can now change "My patterns" to "All patterns" and move to the top of the categories list (no gap in-between). It should include all patterns regardless of source. We can work on a follow up issue to filter patterns by author/source.

We should also update the copy action so it just copies into the same category. Instead of "copy", maybe we can think of a term that's similar to "remix"?

We should also update the copy action so it just copies into the same category. Instead of "copy", maybe we can think of a term that's similar to "remix"?

This originally started out as "Duplicate" and later updated to "Copy to My patterns" as the duplicate couldn't be assigned to the same theme pattern category.

Now the duplicated pattern can reside in the same category, can we just revert back to this option being "Duplicate", like non-theme patterns?

We can also make it such that after duplicating and navigating back to the Patterns page, it goes to the original category not "My patterns", which should remove some forked logic and simplify things.

@SaxonF, @aaronrobertshaw I have replaced My patterns with All patterns and also added categories into the duplication process.

It would be good to add some filters at the top of the pattern list page to just display own synced or unsynced patterns, so have left some of that code in place, but I agree with you @SaxonF that we should handle that in a follow-up issue/PR.

Just testing this one, I tried creating a pattern and assigning it a non-existant category called "Newsletter":

But even upon reloading the Patterns section, I'm not seeing a new "Newsletter" category show up. Am I doing something wrong?

But even upon reloading the Patterns section, I'm not seeing a new "Newsletter" category show up. Am I doing something wrong?

Thanks for testing @jasmussen - this is an issue with the default tag input component as it doesn't register the tag unless you hit enter or add a ',' - I already have an open task to fix this somehow on the tracking issue.

Thanks for the clarification! This is exciting work.

@aaronrobertshaw I think I have fixed the issues with duplicating patterns.

Duplicating some theme patterns also didn't seem to be getting the correct category assigned to them.

Seems to be a caching issue somewhere, will try and work out why sometimes the category lists are not being refreshed when new patterns are added to them

@aaronrobertshaw this change should fix the issue with theme patterns not being added to categories without a page refresh.

This was merged with some failing tests, but is going into a feature branch which needs rebasing to get the failing tests resolved, so failing tests will be sorted on that branch prior to merging to trunk.